Skip to content

Fix some build warnings#132

Merged
ryonakano merged 1 commit into
mainfrom
fix-build-warnings
Jul 12, 2025
Merged

Fix some build warnings#132
ryonakano merged 1 commit into
mainfrom
fix-build-warnings

Conversation

@ryonakano
Copy link
Copy Markdown
Member

@ryonakano ryonakano commented Jul 12, 2025

Fixes the following two warnings:

MainWindow.c: In function ‘_atlas_main_window___lambda10_’:
MainWindow.c:1643:1: warning: no return statement in function returning non-void [-Wreturn-type]
../src/MainWindow.vala: In function ‘atlas_main_window_setup_map_source_action’:
../src/MainWindow.vala:244:172: warning: passing argument 7 of ‘g_settings_bind_with_mapping’ from incompatible pointer type [-Wincompatible-pointer-types]
  244 |         Application.settings.bind_with_mapping ("map-source", map_widget, "map-source", SettingsBindFlags.DEFAULT,
      |                                                                                                                                                                            ^                                                         
      |                                                                                                                                                                            |
      |                                                                                                                                                                            GVariant * (*)(GValue *, const GVariantType *, void *) {aka struct _GVariant * (*)(struct _GValue *, const struct _GVariantType *, void *)}
In file included from /usr/include/glib-2.0/gio/gio.h:137,
                 from /usr/include/gtk-4.0/gtk/css/gtkcsssection.h:24,
                 from /usr/include/gtk-4.0/gtk/css/gtkcss.h:36,
                 from /usr/include/gtk-4.0/gtk/gtk.h:29,
                 from /usr/include/libadwaita-1/adwaita.h:9,
                 from src/com.github.ryonakano.atlas.p/MainWindow.c:10:
/usr/include/glib-2.0/gio/gsettings.h:326:99: note: expected ‘GSettingsBindSetMapping’ {aka ‘struct _GVariant * (*)(const struct _GValue *, const struct _GVariantType *, void *)’} but argument is of type ‘GVariant * (*)(GValue *, const GVariantType *, void *)’ {aka ‘struct _GVariant * (*)(struct _GValue *, const struct _GVariantType *, void *)’}
  326 |                                                                          GSettingsBindSetMapping  set_mapping,
      |                                                                          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

@ryonakano ryonakano merged commit 4aea674 into main Jul 12, 2025
3 checks passed
@ryonakano ryonakano deleted the fix-build-warnings branch July 12, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant