Skip to content

Make it compatible with Rails 7.2#4

Open
edmartins wants to merge 1 commit intoelengine:masterfrom
CareMessagePlatform:rails_7.2
Open

Make it compatible with Rails 7.2#4
edmartins wants to merge 1 commit intoelengine:masterfrom
CareMessagePlatform:rails_7.2

Conversation

@edmartins
Copy link

@edmartins edmartins commented Aug 21, 2025

PgpoolNoLoadBalance::PostgreSQLAdapterMissing: No postgresql adapter specified by 'config/database.yml', or 'ActiveRecord::Base.establish_connection' method is not called. (PgpoolNoLoadBalance::PostgreSQLAdapterMissing)

@edmartins edmartins marked this pull request as ready for review August 21, 2025 21:45
@edmartins edmartins changed the title Rails 7.2 Make it compatible with Rails 7.2 Aug 21, 2025
@elengine
Copy link
Owner

Hi @edmartins,

First of all, thank you so much for your previous pull request for Rails 7.1! I've just merged it, and I really appreciate your help in keeping this library up-to-date.

It's fantastic to see you've already followed up with this PR for Rails 7.2 support. Thank you for your continued effort!

Before I can review this one, could you please take care of a couple of things?

  1. It looks like this branch now has a merge conflict, most likely because the Rails 7.1 PR was just merged. Could you please rebase your branch onto the latest master to resolve it?
  2. Just as a quick check to prevent any regressions, could you also confirm that these changes for 7.2 still work perfectly with Rails 7.1?

Looking forward to getting this merged as well. Thanks again for your great contributions!

@edmartins edmartins force-pushed the rails_7.2 branch 2 times, most recently from 9ebdbec to c360e33 Compare August 28, 2025 12:46
@edmartins
Copy link
Author

edmartins commented Mar 3, 2026

Hi @edmartins,

First of all, thank you so much for your previous pull request for Rails 7.1! I've just merged it, and I really appreciate your help in keeping this library up-to-date.

It's fantastic to see you've already followed up with this PR for Rails 7.2 support. Thank you for your continued effort!

Before I can review this one, could you please take care of a couple of things?

  1. It looks like this branch now has a merge conflict, most likely because the Rails 7.1 PR was just merged. Could you please rebase your branch onto the latest master to resolve it?
  2. Just as a quick check to prevent any regressions, could you also confirm that these changes for 7.2 still work perfectly with Rails 7.1?

Looking forward to getting this merged as well. Thanks again for your great contributions!

Hi @elengine,

The branch has been rebased and there are no conflicts anymore.

The gem already has a versioning strategy tied to Rails compatibility:

  • v1.1.0 → supports ActiveRecord >= 5.2.0 (the older releases)
  • v1.2.0 → supports ActiveRecord >= 7.2.0 (this PR)

Each major Rails version gets its own gem version. The >= 7.2.0 constraint in the gemspec enforces this automatically. When a Rails 7.1 user runs bundle install, Bundler sees that v1.2.0 requires activerecord >= 7.2.0 and automatically resolves to the latest version that satisfies their Rails version instead. No manual pinning needed.

So backward compatibility isn't needed because the gem version boundary IS the compatibility boundary. The tag v1.2.0 signals exactly that, and Bundler enforces it transparently for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants