fix(flterm): support repeated terminal view attachment - #164
Merged
Merged
Conversation
elias8
added
bug
elias8
force-pushed
the
fix/flterm-view-lifecycle
branch
from
September 21, 2026 14:59
c7a617d to
e01f406
Compare
elias8
force-pushed
the
fix/flterm-view-lifecycle
branch
from
September 21, 2026 18:09
e01f406 to
cf10eda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinitialize
ViewAttachmentwhen aTerminalViewis reactivated after keyed replacement, and ignore metric changes while the view is deactivated. This prevents stale attachment state and lifecycle exceptions when the same controller is transferred between terminal views.