Skip to content

add avatar image soppurt#43

Open
NatanAnter wants to merge 5 commits into
masterfrom
add_avatar_placeholder
Open

add avatar image soppurt#43
NatanAnter wants to merge 5 commits into
masterfrom
add_avatar_placeholder

Conversation

@NatanAnter
Copy link
Copy Markdown
Collaborator

No description provided.

@eliiran1231
Copy link
Copy Markdown
Owner

eliiran1231 commented Apr 27, 2026

nice job
one small issue though. the current approach determines wheatear the avatar is an image solely by the value which can be vague and cost performance,
it would be better to create an avatar type in chats.ts that would look something like

export type Avatar = {
type: "image" | "text"
value: string
}

then replace if(IsImage(chat.avatar)) with if(chat.avatar.type == "image")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants