Skip to content

Reduce memory usage in IEx autocomplete module listing #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Mar 6, 2026
Merged

Reduce memory usage in IEx autocomplete module listing #15140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b9bf62
Reduce memory usage in IEx autocomplete module listing
dkuku Mar 6, 2026
ae79f84
Avoid String.split per module in IEx autocomplete
dkuku Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions lib/iex/lib/iex/autocomplete.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,19 +509,25 @@ defmodule IEx.Autocomplete do
end

defp match_elixir_modules(module, hint) do
name = Atom.to_string(module)
depth = length(String.split(name, ".")) + 1
base = name <> "." <> hint
prefix = Atom.to_string(module) <> "."
prefix_size = byte_size(prefix)
base = prefix <> hint

for mod <- match_modules(base, module == Elixir),
parts = String.split(mod, "."),
depth <= length(parts),
name = Enum.at(parts, depth - 1),
rest = binary_part(mod, prefix_size, byte_size(mod) - prefix_size),

@josevalim josevalim Mar 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there may be a bug here. is it guaranteeed that byte_size(mod) - prefix_size is greater than 0?

name = elixir_submodule_name(rest),
valid_alias_piece?("." <> name),
uniq: true,
do: %{kind: :module, name: name}
end

defp elixir_submodule_name(rest) do
case :binary.match(rest, ".") do
{pos, _} -> binary_part(rest, 0, pos)
:nomatch -> rest
end
end

defp valid_alias_piece?(<<?., char, rest::binary>>) when char in ?A..?Z,
do: valid_alias_rest?(rest)

Expand Down Expand Up @@ -604,8 +610,7 @@ defmodule IEx.Autocomplete do

defp match_modules(hint, elixir_root?) do
get_modules(elixir_root?)
|> Enum.sort()
|> Enum.dedup()
|> :lists.usort()
|> Enum.drop_while(&(not String.starts_with?(&1, hint)))
|> Enum.take_while(&String.starts_with?(&1, hint))
end
Expand All @@ -615,7 +620,7 @@ defmodule IEx.Autocomplete do
end

defp get_modules(false) do
modules = Enum.map(:code.all_loaded(), &Atom.to_string(elem(&1, 0)))
modules = Enum.map(:erlang.loaded(), &Atom.to_string/1)

case :code.get_mode() do
:interactive -> modules ++ get_modules_from_applications()
Expand Down
Loading