Skip to content

fix: DateRange invalid slice step computation when step != 1 #15560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 9, 2026
+12 −1
Merged

fix: DateRange invalid slice step computation when step != 1 #15560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/calendar/date_range.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ defmodule Date.Range do
step: step
} = range
) do
{:ok, size(range), &slice(first + &1 * step, step + &3 - 1, &2, calendar)}
{:ok, size(range), &slice(first + &1 * step, step * &3, &2, calendar)}
end

# TODO: Remove me on v2.0
Expand Down
11 changes: 11 additions & 0 deletions lib/elixir/test/elixir/calendar/date_range_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ defmodule Date.RangeTest do

assert Enum.slice(@asc_range_2, 3, 3) == [~D[2000-01-07], ~D[2000-01-09], ~D[2000-01-11]]
assert Enum.slice(@asc_range_2, -3, 3) == [~D[2000-12-28], ~D[2000-12-30], ~D[2001-01-01]]

assert Enum.slice(@asc_range_2, 0..4//2) == [~D[2000-01-01], ~D[2000-01-05], ~D[2000-01-09]]
assert Enum.slice(@asc_range_2, 1..4//2) == [~D[2000-01-03], ~D[2000-01-07]]
end

test "for descending range" do
Expand All @@ -73,6 +76,14 @@ defmodule Date.RangeTest do

assert Enum.slice(@desc_range_2, 3, 3) == [~D[2000-12-26], ~D[2000-12-24], ~D[2000-12-22]]
assert Enum.slice(@desc_range_2, -3, 3) == [~D[2000-01-05], ~D[2000-01-03], ~D[2000-01-01]]

assert Enum.slice(@desc_range_2, 0..4//2) == [
~D[2001-01-01],
~D[2000-12-28],
~D[2000-12-24]
]

assert Enum.slice(@desc_range_2, 1..4//2) == [~D[2000-12-30], ~D[2000-12-26]]
end

test "for empty range" do
Expand Down
Loading