Skip to content

Drop empty map lines in map_fetch_key_static #15593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaszsamson wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Drop empty map lines in map_fetch_key_static #15593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/module/types/descr.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3139,7 +3139,7 @@ defmodule Module.Types.Descr do
end

defp map_fetch_key_static(%{map: bdd}, key) do
bdd |> map_bdd_to_dnf_with_empty() |> map_dnf_fetch_static(key)
bdd |> map_bdd_to_dnf_remove_empty() |> map_dnf_fetch_static(key)
end

defp map_fetch_key_static(%{}, _key), do: {false, none()}
Expand Down
8 changes: 8 additions & 0 deletions lib/elixir/test/elixir/module/types/descr_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,6 +2458,14 @@ defmodule Module.Types.DescrTest do
|> opt_difference(open_map(a: atom([:foo, :bar])))
|> opt_difference(open_map(a: atom([:foo, :baz])))
|> map_fetch_key(:a) == {false, integer()}

t = closed_map(a: term())
knife = open_map(c: none())
cover = opt_union(t, knife)
t2 = opt_difference(cover, opt_difference(cover, t))
assert equal?(t, t2)
assert map_fetch_key(t, :a) == {false, term()}
assert map_fetch_key(t2, :a) == map_fetch_key(t, :a)
end

# Times out without a projection-only map_fetch_key path
Expand Down