wip: using {active, 100} instead of recv#88
Draft
tsloughter wants to merge 3 commits intoelli-lib:developfrom
Draft
wip: using {active, 100} instead of recv#88tsloughter wants to merge 3 commits intoelli-lib:developfrom
tsloughter wants to merge 3 commits intoelli-lib:developfrom
Conversation
Member
|
This needs a rebase of course, but would be nice to sneak into 4.0. Conceptually I'm down, so long as it's configurable in the end. |
yurrriq
requested changes
Feb 2, 2021
Member
yurrriq
left a comment
There was a problem hiding this comment.
Needs a rebase (onto main) and the ability to set n, otherwise looking good
Draft
Member
Author
|
Cool. I'd like to get some performance testing done. This is a major change since elli wasn't even use This might be more useful in like http2 (plan to try it in chatterbox) or streaming http1 requests. When a body size is available it might be better to keep it as just calling |
Member
|
let's not rush it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few quick benchmarks just on my laptop with
wrkshowed a consistent improvement over use ofrecv.I'd like to try some more values of
nincluding{active, once}both just to see if there are any clear differences and to tune the default. (Oh right, need to makenoverridable as well before this is ready for possible merge.)