refactor(logs): rename Reports logs sql field to safeSql - #12
Merged
Merged
Conversation
## Context Just removing unified logs related dead code (Not used, not imported) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Streamlined the Service Flow view by removing legacy timeline, collapsible sections, and some detailed step UI for a cleaner visualization. * Simplified the Unified Logs surface by reducing exposed types, consolidating query logic, and removing an internal event bus. * Removed legacy list/detail and sheet UI pieces to tighten the logs interface and public API surface. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46459?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46459?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack){kind=link}
Renames the `sql:` field on `ReportQueryLogs` to `safeSql:` so its naming matches `ReportQueryDb`, which already uses `safeSql:` for branded fragments. Earlier branding PRs migrated every logs preset to return `SafeLogSqlFragment` in place, leaving the field name `sql:` as the last holdover from the pre-branding world. This rename is purely cosmetic — the underlying values, callers, and types are unchanged. Touches: - ReportQueryLogs type (Reports.types.ts) - Every Logs preset under PRESET_CONFIG[API|STORAGE] (Reports.constants.ts) - All entries + call sites in SharedAPIReport.constants.ts - getLogsSql in Reports.utils.tsx Part of the analytics SQL safety series; PRs 10 (remaining analytics callers) and 11 (boundary lock-down) still to follow.
Braintrust eval reportEvals failed: Error: Command failed with exit code 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of supabase/supabase#46469 by @charislam