Repository navigation
Round 8 + final review fixes: captain prepares, engine room runs; clean demo; SECURITY.md (merge after Codex MERGE-FÄHIG + green CI, merge commit) - #7
Merged
Conversation
Lukas's GUI test on 2026-10-13, round 8: - "+ New use case" (My use cases) and "+ New blueprint" (Blueprints) open a small form - a name and a first step - and the dialog that opens next takes further steps; an own blueprint is stored as a template. - Echo sounding moves to Folders, next to the folders it listens to. NemoFold has no scheduler of its own: a scheduled use case writes a task file the person installs, and the echo shows the runs it produced. - The research notebook tile says "Start" instead of "Open": it is no configurable workflow. - F1 from the PR #6 review: no blank line at the end of model_planner.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FMTv7ecoTBXem1ndYqUtxj
… workflow
Lukas, 2026-10-13: "Run it ... schlecht gewählt. Wir wollen noch keinen run
es sollte nur prepare voyage sein und wenn es eine kombination ist wird im
hintergrund der workflow angelegt und nutzer informiert ..."
- The captain offers Prepare voyage only. A plan of several steps is first
kept as one new workflow under My use cases ("New workflow created: ..."),
its steps go to the job inbox, and step 1 loads into the engine room.
- The engine room names the loaded workflow at its top and runs all its
steps in order on request (local, dry run), or one step at a time.
- Local model servers that do not answer stay listed at the captain as
"not reachable right now" instead of vanishing; the transfer approval
checkbox sits next to its sentence.
Full suite 1187 passed, 2 skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HwEgw7w5b64hDRLmCG3okz
…oved Final acceptance review (advisor) on 2026-10-13: - The public demo runs the same wheel but showed full-console controls that answered 404 there: the captain, working folders, echo sounding, "+ New use case/blueprint", library adopt/remove buttons and the policy editor. They are marked data-full-only and hidden when the server reports the demo; a click sweep over all seven demo views now finds no 4xx answer and no page error. - Preparing the same plan again reuses the combined workflow it already created instead of adding "(2)" copies. - SECURITY.md listed four mail addresses on domains that do not exist (ellmos.ai, open-bricks.org) or have no MX record (lukasgeiger.com); a report there would vanish. GitHub private vulnerability reporting is enabled and is now the only channel named. - README EN/DE: the captain only prepares, the engine room runs the combined workflow; new entries from scratch; echo on Folders; the demo's scope. Full suite 1187 passed, 2 skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwEgw7w5b64hDRLmCG3okz
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
Codex review of PR #7: "Run all steps" stayed active during /api/voyage-run, so a double click started the chain twice with different run IDs. The button is disabled for the run and an in-flight guard ignores further clicks; measured in the browser: three quick clicks, one /api/voyage-run request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwEgw7w5b64hDRLmCG3okz
Member
Author
|
Merged by Codex (OpenAI) as second-model reviewer per owner decision D-048; verdict MERGE-FÄHIG; CI green on head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge condition
Merge only after the second-model review (Codex) says MERGE-FÄHIG and the
cichecks of this PR's head are green. Use a merge commit (no squash). Owner decision D-048: Codex may merge this PR after that review; nobody merges by admin.What this is
Round 8 of the owner's GUI test and the fixes from the final acceptance review, on top of #6.
Evidence
Local full suite 1187 passed, 2 skipped. Browser checks of every changed flow (Playwright) against the live console and a demo server.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HwEgw7w5b64hDRLmCG3okz