Skip to content

Update to 1.3 - #22

Open
TMPhoenix wants to merge 7 commits into
elmindra:masterfrom
TMPhoenix:master
Open

TMPhoenix wants to merge 7 commits into
elmindra:masterfrom
TMPhoenix:master

Conversation

@TMPhoenix

Copy link
Copy Markdown

Fixed issue with mergeids of my previous pull request

@elmindra

elmindra commented Apr 4, 2019

Copy link
Copy Markdown
Owner

Taking a look now, thank you!

@elmindra

elmindra commented Apr 4, 2019

Copy link
Copy Markdown
Owner

thank you so much ... this was a huge help in tracking it down!

I did mostly the same fix but with a few slight differences:

  • removed the "spellbook UI" icon patch, as it's not necessary anymore (the game included the fix)
  • switched to using two UInt64s for the Guid xor method, removed use of BigInteger

The rest of the fixes should be the same as your version. Let me know if I missed anything.

(commit was a95e74f , updated build available at https://github.com/jennyem/pathfinder-mods/releases/tag/0.9.6)

@TMPhoenix

Copy link
Copy Markdown
Author

I wasn't sure about the UI patch, as I couldn't tell from the functions Owlcat was using whether it also returned anything related to the archetypes.
I didn't choose UInt64 for 3 reasons:

  • GUIDs can have arbitrary length (since they are just strings) so numbers larger than UIN64MAX are possible
  • BigInteger is signed, so using Uint would cause backwards compatibility issues
  • I wasn't sure the printing of Uint64 would be identical, as BigInteger is rather quirky sometimes
    My implementation of BigInteger seems to behave identical now for the use cases in EA, including the negation stuff, so personally I would go with mine, since I know of at least a few cases where negation was a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants