Add handling of new GCP families c4d, m4 and a4#4
Merged
selvik merged 3 commits intofix/google_machine_type_per_zonefrom Aug 25, 2025
Merged
Add handling of new GCP families c4d, m4 and a4#4selvik merged 3 commits intofix/google_machine_type_per_zonefrom
selvik merged 3 commits intofix/google_machine_type_per_zonefrom
Conversation
selvik
changed the title
murbans1
approved these changes
Aug 25, 2025
selvik
merged commit d80c693
into
fix/google_machine_type_per_zone
3 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handling of new GCP instance type families c4d, m4 and a4. Without this addition, new families were reporting on demand price of 0.
How was this tested?
Cloud info was run for Google cloud provider. Generated Json files were sampled for newer instance families such as "c4d-highmem-16". Further ensured that no zero ondemand prices existed:
\"onDemandPrice\": 0