[feature] CI: automate goquery-ui chart release on tagged app builds#477
Merged
Conversation
Adds a release-chart job to build-docker.yml implementing avenue 2 of the chart release model: on a final v*.*.* tag, after the frontend image is pushed, retarget the chart's appVersion to it, patch-bump the chart's own version:, publish the chart to GHCR, and commit both fields back to main as bookkeeping. Publishes straight from the tag via `helm package --app-version`, which sidesteps the GITHUB_TOKEN re-trigger rule and needs no PAT. Idempotent on appVersion, so re-runs and partial failures converge without minting a spurious chart version. Skips prerelease tags. Documented in docs/adr/0002 and CONTEXT.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Automates avenue 2 of the goquery-ui chart release model (PR #476): a tagged app release now retargets the chart's
appVersion, bumps itsversion:, ships the chart, and records the bump onmain— no manual edit.Adds a
release-chartjob to build-docker.yml:needs: [build-docker]— runs only after thegoprobe/frontendimage is pushed, so the chart never pins an image that doesn't exist yet.if: !contains(github.ref_name, '-')— final tags only; prereleases (-rc*) build images but never ship a chart.appVersionfrommain; idempotency guard: if it already equals the tag, the job is a no-op (re-runs and partial-failure retries converge).version:, setsappVersionto the tag'sX.Y.Z(surgicalsed, preserving the chart's comments/spacing),helm package, GHCR existence check,helm push, then commits both fields back tomainwithGITHUB_TOKENunder a[trivial]message.Why this shape
Publishing straight from the tag via
helm package --app-versionsidesteps the well-known rule that aGITHUB_TOKENpush does not re-trigger another workflow — so we need no PAT, norepository_dispatch, and no second publish path. The "won't re-trigger" behaviour becomes a feature (no double publish). Alternatives weighed (always-latest, commit-back-with-PAT) and the rationale are in ADR 0002; shared vocabulary is in CONTEXT.md.publish-chart.ymlis unchanged and remains the path for avenue 1 (chart-only changes merged tomain).Test plan
Verified locally:
0.1.1 → 0.1.2,appVersion → "4.3.0".sededit touches only the two value lines;apiVersionuntouched; comments/spacing preserved.Exercised live only on the first real
v*.*.*tag (helm GHCR push +GITHUB_TOKENpush tomainneed a runner).🤖 Generated with Claude Code