Claude/metrics improvements g zlv j#7
Merged
Conversation
- Fix "reponse" typo in metrics help text - Remove unnecessary loop variable copy in registerMetrics https://claude.ai/code/session_011rJHSN2dVRXMtf67yy3NkF
…ort (Phase 4) BREAKING CHANGES: - NewPrometheus now requires a *prometheus.Registry parameter (pass nil for a fresh registry, or the default registry for backward compat). This prevents panics from duplicate metric registration in tests. - HandlerFunc() renamed to GinHandlerFunc() to avoid confusion with the new net/http HandlerFunc(next) middleware. - reqSz/resSz changed from Summary (which was useless without quantile objectives) to Histogram with exponential buckets. New features: - H7: Accept *prometheus.Registry instead of using the global registry - H7: Add net/http middleware via HandlerFunc(next http.Handler) http.Handler - H7: Add MetricsHandler() for serving metrics in net/http setups - H7: Expose pathLabelFromContext via WithPathLabelFromContext option (was dead code with no public setter) - H7: Fix unsafe type assertion on context value (now checks type) - H7: responseWriter wrapper for net/http to capture status and size https://claude.ai/code/session_011rJHSN2dVRXMtf67yy3NkF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.