feat!: improve tracing with lazy gRPC, sampler config, and drop viper (Phase 3)#9
Merged
Merged
Conversation
els0r
changed the title
… (Phase 3) BREAKING CHANGES: - WithGRPCExporter no longer blocks on dial; uses grpc.NewClient for lazy connection. Applications relying on Init failing when collector is down should add health checks instead. - Default sampler changed from AlwaysSample to ParentBased(AlwaysSample), which respects parent span sampling decisions (OTel default). - Viper dependency removed from flags.go; flag values are now read directly from the pflag.FlagSet. Callers using viper.BindPFlags separately will need to read flag values themselves. - Removed exported default/help constants (TracingEnabledDefault, etc.) that were implementation details. New features: - H5: Replace deprecated grpc.DialContext+WithBlock with grpc.NewClient - H5: Add WithTransportCredentials option for TLS support - M3: Add WithSampler option for configurable trace sampling - M6: Add WithResource option for explicit resource configuration - M7: Remove viper dependency (~15 transitive deps eliminated) https://claude.ai/code/session_011rJHSN2dVRXMtf67yy3NkF
els0r
force-pushed
the
claude/tracing-redesign-GZlvJ
branch
from
1c01c74 to
6880845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
connection. Applications relying on Init failing when collector is down
should add health checks instead.
which respects parent span sampling decisions (OTel default).
from the pflag.FlagSet. Callers using viper.BindPFlags separately will
need to read flag values themselves.
that were implementation details.
New features: