chore: bump ElsaVersion and ElsaStudioVersion to 3.8.2 - #207
Merged
Merged
Conversation
Retarget central Elsa core and Studio package pins so extensions can republish Mongo/Dapper from the release/3.8.2 tip against published 3.8.2 packages. Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
sfmskywalker
marked this pull request as ready for review
September 15, 2026 20:12
sfmskywalker
commented
Sep 15, 2026
sfmskywalker
left a comment
Member
Author
There was a problem hiding this comment.
Code Review — Round 1/4 (tip-bound)
Verdict: APPROVE + HIGH
Tip: 5979edb8cda5a0c59d756bfdf17551096bbaf79d → release/3.8.2
Scope: Directory.Build.props only — ElsaVersion and ElsaStudioVersion 3.8.1 → 3.8.2.
Why APPROVE + HIGH
- Minimal, correct 3.8.2-train republish pin (same pattern as prior ElsaVersion bumps).
Directory.Packages.propsalready uses$(ElsaVersion)/$(ElsaStudioVersion); no leftover hardcoded3.8.1PackageVersion pins in that file. - nuget.org has Elsa / Elsa.Studio / Elsa.Studio.Workflows / Elsa.Api.Client at 3.8.2 — pins are resolvable.
- Patch-safe for
release/3.8.2; no code/API surface in this PR. Leavingpackages.ymlbase_versionat 3.8.0 is correct (extensions package version, not an Elsa.* pin). - Human-maintainable: two central properties, no cleverness.
Soft (non-blocking)
- Tip CI when reviewed: GitGuardian + CLA +
submit-nugetgreen. Merge when the suite you treat as required for this branch is green on tip.
Merge gate
Greptile waived on elsa-extensions. Merge on APPROVE+HIGH ∧ CI green.
Formal event: COMMENT (own-PR APPROVE blocked for author). Round 1 tip-frozen at 5979edb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump central Elsa core and Studio package pins from 3.8.1 to 3.8.2 so extensions packages can republish from the correct
release/3.8.2tip against published core + studio 3.8.2.This is the consumer fix path for #205: the 3.8.1 Mongo/Dapper nupkgs were packed before
c9f83e5/0619be9, so they do not implement the 3-parameterTryMarkInterruptedAsyncadded in core 3.8.1. Republishing Mongo/Dapper from this tip with matching 3.8.2 pins lets hosts load against Elsa 3.8.2.Why
Elsa/Elsa.Studiofetchable).Elsa.*/Elsa.Studio.*viaElsaVersion/ElsaStudioVersionat 3.8.1.Changes
Directory.Build.props:ElsaVersionandElsaStudioVersion3.8.1→3.8.2Directory.Packages.propsalready uses$(ElsaVersion)/$(ElsaStudioVersion); no scatteredPackageReference/PackageVersionpins were still hardcoded to 3.8.1.github/workflows/packages.ymlbase_versionat 3.8.0 (extensions publish version, not an Elsa.* pin). This PR does not retag or publish.Verify
dotnet restore Elsa.Extensions.slnsucceeded (exit 0)Elsa.Workflows.Management/3.8.2andElsa.Studio.Workflows/3.8.2(no leftoverElsa*/3.8.1inproject.assets.json)dotnet buildofElsa.Email,Elsa.Studio.WorkflowsContexts,Elsa.Persistence.MongoDb, andElsa.Persistence.Dapper(net10.0) succeeded with 0 errorsdotnet testElsa.MongoDb.UnitTests27 passed;Elsa.Dapper.UnitTests16 passed (net10.0)TryMarkInterruptedAsyncon Mongo + Dapper stores (the 3.8.1 NuGet artifacts are stale:MongoWorkflowInstanceStore/DapperWorkflowInstanceStoredon't implement `IWorkflowInstanceStore.TryMarkInterruptedAsync #205 gap is a stale 3.8.1 nupkg, not missing source)Base tip confirmed:
0619be93onrelease/3.8.2.