ci: build and test elsa-studio on pull requests - #1022
Merged
Merged
Conversation
Add .github/workflows/pr.yml, mirroring the build half of packages.yml (dotnet build/test, client asset builds, and the generated BPMN types check) so PRs are verified before merge instead of relying on local runs and post-merge checks. Update the now-stale comment in packages.yml that claimed there was no PR-time build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Pin actions/checkout and actions/setup-dotnet to the commit SHA their v4 tag currently resolves to, and add actions/setup-node (also pinned by SHA) ahead of the first npm step so the workflow no longer depends on the runner's implicit default Node. node-version 22 matches both the Node.js version actually preinstalled on the runner image used by the green PR #1022 run (22.23.2) and vitest's supported engines range. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1017.
What changed
Pull requests to
mainnow build and test elsa-studio. Until now PR checks were CodeQL, GitGuardian, Greptile and the CLA only;packages.ymlbuilt and tested only after merge, so every recent Studio PR was verified by local runs alone..github/workflows/pr.ymlmirrors the build half ofpackages.yml, without packing or publishing. In order, it:Bpmn.Model;npm install --force, thennpm run check:generatedandnpm testbeforenpm run build, because the build regenerates the types file and would otherwise hide a stale commit;dotnet build Elsa.Studio.sln --configuration Releaseanddotnet test Elsa.Studio.sln --configuration Release --no-build.It sets
permissions: contents: read, uses no secrets (safe for fork PRs), cancels superseded runs for the same PR, and times out at 30 minutes. Node comes from the runner, as inpackages.yml. The few shared steps are duplicated because the repository has no composite actions or reusable workflows to share them from. The stale comment inpackages.ymlthat said no PR-time build exists is corrected.Verification
The same commands, run locally in order on this branch, all pass: the ClientLib types check, 238 vitest tests, both ClientLib builds, the Release solution build with 0 errors, and
dotnet testwith every project green. The workflow's own run on this PR is the real proof.Review: one iteration on the standards and spec axes. One won't-fix is recorded: this uses
actions/checkout@v4whilepackages.ymlstill pins@v3, which runs on a deprecated Node runtime.🤖 Generated with Claude Code