refactor(workflows): drop the BpmnProcess port provider now that core declares its outcomes - #1027
Merged
Merged
Conversation
…s declares its own flow ports elsa-core's BpmnProcess now declares Done and Cancelled via [FlowNode] (elsa-workflows/elsa-core#8066), so the descriptor already carries both flow ports and the provider that used to synthesize them is a no-op superset. Removed the provider and its registration, trimmed the now- unused CancelledOutcomeName/OutcomeNames off BpmnProcessConstants (ActivityTypeName and DoneOutcomeName are still used elsewhere), and replaced the provider tests with one that feeds a descriptor shaped like the new server response through the default port path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…rtsTests The deleted BpmnProcessPortProvider no longer exists; the test now exercises DefaultActivityPortProvider against the server's Elsa.BpmnProcess descriptor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1019. Part of elsa-workflows/elsa-core#7909.
What changed
BpmnProcessPortProviderexisted only because elsa-core'sBpmnProcessdeclared no outcomes (#1002). Since elsa-workflows/elsa-core#8066,BpmnProcesscarries[FlowNode(Done, Cancelled)], so the server's descriptor lists both flow ports and the provider is a no-op superset.BpmnProcessPortProviderand its registration.BpmnProcessConstantskeepsActivityTypeNameandDoneOutcomeName, which are still used by the designer provider, the wrapper, display settings and tests. The unusedCancelledOutcomeNameandOutcomeNamesare removed.BpmnProcessPortsTests. It feeds a descriptor shaped like the server's response through the default port path and assertsDoneandCancelledappear as flow ports, with nothing synthesized.Verification
The nested-scope drill-down tests from #1002 still pass.
Review: the standards and spec axes, both clean. One judgement was taken: the test class was renamed from the deleted provider's name.
🤖 Generated with Claude Code