fix: clear structured logs after authorization denial - #1047
Merged
Merged
Conversation
…nial-state fix: clear structured logs on authorization denial
5 tasks
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| private sealed class DenyingHandler(HttpStatusCode statusCode) : HttpMessageHandler | ||
| { | ||
| protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) => | ||
| Task.FromResult(new HttpResponseMessage(statusCode)); |
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+643
to
+646
| if (status is StructuredLogConnectionStatus.Unauthorized or StructuredLogConnectionStatus.Unavailable) | ||
| { | ||
| await EnterTerminalFailureAsync(status); | ||
| return; |
Contributor
There was a problem hiding this comment.
When the live SignalR structured-logs hub returns 404, it reports Unavailable. REST sources and historical rows have already loaded at this point, but this branch sends that state through the terminal failure path and clears them. Keep Unavailable as a live-subscription failure so users can still inspect available REST history; only authorization denial should purge buffered data. This is a non-blocking concern, but it makes diagnostics unavailable when only live updates are missing.
Knowledge Base Used: Structured log diagnostics
Artifacts
- The exact shell script authored and executed to attempt the focused bUnit runtime check, then to assert the narrow source conditions when the required .NET runtime was unavailable; it documents the reproducible verification path.
- Output captured from executing the evidence script in `/home/user/repo`; it records the missing dotnet blocker and passing focused assertions, confirming the status mapping, load order, and clear behavior.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/modules/Elsa.Studio.Diagnostics.StructuredLogs/UI/Pages/StructuredLogs.razor.cs
Line: 643-646
Comment:
**Preserve history when unavailable**
When the live SignalR structured-logs hub returns 404, it reports `Unavailable`. REST sources and historical rows have already loaded at this point, but this branch sends that state through the terminal failure path and clears them. Keep `Unavailable` as a live-subscription failure so users can still inspect available REST history; only authorization denial should purge buffered data. This is a non-blocking concern, but it makes diagnostics unavailable when only live updates are missing.
**Knowledge Base Used:** [Structured log diagnostics](https://app.greptile.com/skywalker-digital/-/custom-context/knowledge-base/elsa-workflows/elsa-studio/-/docs/structured-log-diagnostics.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Structured Logs page could leave buffered rows visible after REST or SignalR authorization failed. It now treats 401/403 as a terminal denied state, clears rows, selected details, source metadata and counters, disposes the observer, and suppresses late callbacks.
Validation: the focused Structured Logs suite passes 21/21 and
git diff --checkpasses. Root self-review removed duplicate observer disposal and added an idempotency assertion.Refs #1045 and valence-works/elsa-control#475.