Skip to content

fix: defer structured logs scrolling until interactive render - #1051

Merged
sfmskywalker merged 1 commit into
mainfrom
codex/structured-logs-prerender-safe-scroll
Sep 17, 2026
Merged

sfmskywalker merged 1 commit into
mainfrom
codex/structured-logs-prerender-safe-scroll

Conversation

@sfmskywalker

Copy link
Copy Markdown
Member

What changed

Structured Logs can load during server prerendering, but its initial auto-scroll tried to import the browser JavaScript module before an interactive render existed. The page now queues scrolling until OnAfterRenderAsync, coalesces requests made before interactivity, and keeps the existing auto-scroll behavior after the circuit starts. A terminal authorization failure discards any queued scroll.

The tests cover static HTML rendering without page JavaScript interop or a surfaced interop error, plus scrolling after an interactive render.

Fixes #1050
Refs valence-works/elsa-control#475

Validation

  • dotnet test src/modules/Elsa.Studio.Diagnostics.StructuredLogs.Tests/Elsa.Studio.Diagnostics.StructuredLogs.Tests.csproj --no-restore — passed, 23/23.
  • git diff --check — passed.

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

No confirmed issue blocks merging; the focused rendering coverage remains unexecuted because the environment lacks .NET.

What we checked:

  • T-Rex executed the validation script to run the StructuredLogs tests. T-Rex
  • The shell reported dotnet not found on PATH, so the test command exited with code 127. T-Rex
  • Because dotnet was missing, net10.0 bUnit/HtmlRenderer validation and Playwright UI capture could not be executed. T-Rex
  • Artifacts were captured documenting the attempt, including the validation script and three related logs. T-Rex

Summary

Defers Structured Logs JavaScript scrolling until the component has completed an interactive render.

  • Coalesces pre-interactivity scroll requests into one pending operation.
  • Cancels pending scrolling after terminal authorization failures.
  • Adds static-prerender and interactive-scroll coverage.

T-Rex validation blocked

  • The focused Structured Logs rendering checks could not run because the required .NET CLI is unavailable in this environment.

Reviews (1) · Last reviewed commit: "fix: defer structured logs scrolling unt..."

@sfmskywalker
sfmskywalker merged commit f6ad44a into main Sep 17, 2026
10 checks passed
@sfmskywalker
sfmskywalker deleted the codex/structured-logs-prerender-safe-scroll branch September 17, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Structured Logs scrolling safe during prerendering

1 participant