fix: defer structured logs scrolling until interactive render - #1051
Merged
Merged
Conversation
Contributor
|
sfmskywalker
deleted the
codex/structured-logs-prerender-safe-scroll
branch
September 17, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Structured Logs can load during server prerendering, but its initial auto-scroll tried to import the browser JavaScript module before an interactive render existed. The page now queues scrolling until
OnAfterRenderAsync, coalesces requests made before interactivity, and keeps the existing auto-scroll behavior after the circuit starts. A terminal authorization failure discards any queued scroll.The tests cover static HTML rendering without page JavaScript interop or a surfaced interop error, plus scrolling after an interactive render.
Fixes #1050
Refs valence-works/elsa-control#475
Validation
dotnet test src/modules/Elsa.Studio.Diagnostics.StructuredLogs.Tests/Elsa.Studio.Diagnostics.StructuredLogs.Tests.csproj --no-restore— passed, 23/23.git diff --check— passed.