fix: resolve .cmd wrapper to actual JS entry on Windows#32
Merged
Conversation
On Windows, npm global installs create a .cmd shim for CLI tools. The extension was passing this .cmd file to `node`, causing: SyntaxError: Invalid or unexpected token (@echo off) Fix: Parse the .cmd wrapper to extract the real JS entry script path and pass that to node instead. Falls back to checking node_modules/conduit-bridge/dist/cli.js directly. Also prioritizes direct JS entry point candidates before shell wrappers for more reliable cross-platform behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
npm install -g conduit-bridgecreates a.cmdshim wrapper. The extension was passing this.cmdfile tocp.spawn('node', [bridgePath, ...]), causing:Bridge would crash 3 times and stop auto-restarting.
Fix
_resolveCmd()method parses the.cmdwrapper to extract the actual JS entry script path_findBridgeCli()now prioritizes direct JS entry points (dist/cli.js) before shell wrappers.cmdcandidate is resolved to its JS target before returningnode_modules/conduit-bridge/dist/cli.jsrelative to npm prefixTesting
npm run build).cmdparsing logic against standard npm-generated shim format