Change Constant Speed slider step from 100 to 25 RPM#112
Merged
Conversation
A single 100 RPM click moved flow by roughly 20-25%, which is coarse for a setpoint users tune by feel. Field testing in the issue stepped 1650 to 1800 RPM in 25 RPM increments and each one produced a distinct, progressively higher flow, so the pump genuinely resolves this step size. 25 also divides the 500 RPM floor evenly, so hardware minimums like the 1650 RPM clamp are directly selectable instead of having to undershoot and wait for the pump to clamp back up. Range (500-4500 RPM) is unchanged; only the increment changes. Tested: `esphome config` resolves step to 25.0 and the generated main.cpp emits traits.set_step(25.0f); full ESP-IDF build succeeds with 0 warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108.
Change
packages/alpha_hwr_controls.yaml— the Constant Speed Setpoint number entity now usesstep: 25instead ofstep: 100. Range (500-4500 RPM) is unchanged; only the increment moves.Why
Per the issue's field testing:
Testing
esphome configresolves the entity tostep: 25.0, and the generatedmain.cppemitsconstant_speed_setpoint->traits.set_step(25.0f).