Fix schedule read and write timeouts by eman · Pull Request #93 · eman/esphome-alpha-hwr

eman · 2026-07-16T16:23:10Z

Resolves the Command timeout waiting for Obj 56833 Sub 0 warning by ensuring schedule commands correctly match responses.

Updates schedule_service.cpp to pass 0, 0 as the expected Object ID and Sub ID to enable wildcard matching, instead of incorrectly passing the payload type indicator (0xDE01, 0xDA01, 0xDC01).
Simplifies the Short ACK parser in transport.cpp to correctly respect wildcard matching and the expect_short_ack flag, replacing the hardcoded Object ID whitelist.

Copilot

Pull request overview

This PR aims to eliminate schedule read/write timeouts by improving how queued schedule commands match incoming pump responses in the alpha_hwr transport layer.

Changes:

Updates schedule operations to use wildcard response matching (expect_obj_id=0, expect_sub_id=0) rather than incorrectly keying matching off type bytes like 0xDE01/0xDA01/0xDC01.
Simplifies the short Class 10 ACK matching logic in Transport::try_dispatch_response() by removing a hardcoded whitelist and relying on wildcard/flag-based matching.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
components/alpha_hwr/transport.cpp	Loosens/simplifies short Class 10 ACK matching logic for queued commands.
components/alpha_hwr/schedule_service.cpp	Changes schedule read/write calls to pass `(0,0)` for expected Obj/Sub to rely on wildcard response matching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  this->transport_.send_apdu_command(
-      apdu, 5, 0xDA01, 0,
+      apdu, 5, 0, 0,
      [this](bool success, const uint8_t *payload, size_t payload_len) {


  this->transport_.send_apdu_command(
-      apdu, 5, 0xDE01, 0,
+      apdu, 5, 0, 0,
      [this, entries, layer](bool success, const uint8_t *payload,
                             size_t payload_len) {


  this->transport_.send_apdu_command(
-      apdu, 5, 0xDE01, 0,
+      apdu, 5, 0, 0,
      [this, on_complete, layer](bool success, const uint8_t *payload,
                                 size_t payload_len) {


    this->transport_.send_apdu_command(
-      apdu, 5, 0xDC01, 0,
+      apdu, 5, 0, 0,
        [this, idx, events, on_complete, max_events,
         read_next](bool success, const uint8_t *payload, size_t payload_len) {


  this->transport_.send_apdu_command(
-      apdu, sizeof(apdu), 0xDE01, 0,
+      apdu, sizeof(apdu), 0, 0,
      [on_complete, layer](bool success, const uint8_t *data, size_t len) {


  this->transport_.send_apdu_command(
-      apdu, sizeof(apdu), 0xDE01, 0,
+      apdu, sizeof(apdu), 0, 0,
      [this, on_complete, layer](bool success, const uint8_t *data,
                                 size_t len) {


  this->transport_.send_apdu_command(
-      apdu, sizeof(apdu), 0xDC01, 0,
+      apdu, sizeof(apdu), 0, 0,
      [this, on_complete, event](bool success, const uint8_t *data,
                                 size_t len) {


    if (queued_class == 0x0A && len >= 6 && data[4] == 0x0A && (data[5] == 0x01 || data[5] == 0x81) &&
-        cmd.expect_obj_id == 0x0000 && cmd.expect_sub_id == 0x0000 &&
-        cmd.packet.size() > 9 &&
-        (cmd.packet[5] == 0x97 || cmd.packet[5] == 0x96 || cmd.packet[5] == 0xB3 || 
-         cmd.packet[5] == 0x95 || cmd.packet[5] == 0x91 || cmd.packet[5] == 0x90) &&  // queued OpSpec
-        ((cmd.packet[6] == 91 && cmd.packet[7] == 0x01 && cmd.packet[8] == 0xAE) || // old format
-         (cmd.packet[6] == 0x01 && cmd.packet[7] == 0xAE && cmd.packet[8] == 0x00 && cmd.packet[9] == 91) || // new format SubID 430 Obj 91
-         (cmd.packet[6] == 0x56 && cmd.packet[7] == 0x00 && cmd.packet[8] == 0x06 && cmd.packet[9] == 0x01))) {  // Sub 5600 Obj 0601 (mode write)
+        (cmd.expect_short_ack || (cmd.expect_obj_id == 0x0000 && cmd.expect_sub_id == 0x0000))) {
      uint8_t err_code = (len >= 7) ? data[6] : 0xFF;


…ement

…e hangs

…ue timeouts

… to 1s

…abled

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

+          ESP_LOGW(TAG, "Failed to poll schedule state (timeout). Assuming schedule is disabled by pump mode.");
+          this->schedule_enabled_ = false;
+          this->schedule_state_cached_ = true;
+          this->overview_cached_ = true; // MUST set this so is_fully_synced() can succeed!
+          if (this->state_change_callback_) {
+            this->state_change_callback_(false);
+          }


        if (on_complete)
          on_complete(true);
      },
-      3000);
+      3000, false, true);


+
+def set_mode(mode):
+    print(f"Setting mode to {mode}...")
+    url = f"{HOST}/api/services/select/select_option"
+    res = requests.post(url, headers=HEADERS, json={"entity_id": "select.alpha_hwr_pump_control_mode", "option": mode}, verify=False)
+    res.raise_for_status()
+
+def set_flow(value):
+    print(f"Setting flow setpoint to {value}...")
+    url = f"{HOST}/api/services/number/set_value"
+    res = requests.post(url, headers=HEADERS, json={"entity_id": "number.alpha_hwr_constant_flow_setpoint", "value": value}, verify=False)
+    res.raise_for_status()
+
+def set_switch(entity_id, enabled):
+    print(f"Setting {entity_id} to {enabled}...")
+    url = f"{HOST}/api/services/switch/turn_{'on' if enabled else 'off'}"
+    res = requests.post(url, headers=HEADERS, json={"entity_id": entity_id}, verify=False)
+    res.raise_for_status()
+
+def get_state(entity_id):
+    url = f"{HOST}/api/states/{entity_id}"
+    res = requests.get(url, headers=HEADERS, verify=False)
+    res.raise_for_status()
+    return res.json().get("state")


…rification

Fix schedule read and write timeouts

2dab0ad

eman requested a review from Copilot July 16, 2026 16:25

Copilot started reviewing on behalf of eman July 16, 2026 16:26 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

eman added 4 commits July 16, 2026 11:38

Address review comments: Explicit Obj/Sub matches and Short ACK refin…

e98bcb5

…ement

Fix Obj 84 Sub 900 schedule read timeout

6bac4ab

Unconditionally accept Negative ACKs for all commands to prevent queu…

c8fe41d

…e hangs

Fix Class 10 SET timeouts by enforcing expect_short_ack=true

ae70018

eman force-pushed the fix-schedule-timeouts branch from 9f33728 to ae70018 Compare July 16, 2026 20:06

eman added 2 commits July 16, 2026 13:15

Abort schedule reads when schedule is disabled to prevent massive que…

08a307f

…ue timeouts

Fix compiler warnings for string formatting and buffer size

3d81e0e

eman force-pushed the fix-schedule-timeouts branch from e7f123e to 3d81e0e Compare July 16, 2026 20:18

eman added 9 commits July 16, 2026 13:19

Fix uint32_t formatting warnings in alpha_hwr.cpp

2215112

Assume schedule is disabled if poll_state times out, reducing timeout…

6fb97f3

… to 1s

Fix incorrect timeout argument position in send_apdu_command

8585f2e

Fix double-callback and recursion unwinding logs when schedule is dis…

2c5e6a2

…abled

Update CHANGELOG.md with schedule and queue timeout fixes

385ac33

update changelog

7c5c368

Remove faulty Object 84 workaround from transport dispatcher

e4ffd80

Fix pump commands being rejected when schedule reads timeout

bfa52e4

Update CHANGELOG.md with recent PR #93 fixes

8302abd

eman requested a review from Copilot July 17, 2026 05:54

Copilot started reviewing on behalf of eman July 17, 2026 05:54 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

eman added 3 commits July 16, 2026 23:05

Address review comments: cache flags, completion callback, and TLS ve…

3113876

…rification

Remove accidental tracking of scratch files and test yaml

1dc5a22

checkpoint

788454e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix schedule read and write timeouts#93

Fix schedule read and write timeouts#93
eman wants to merge 19 commits into
mainfrom
fix-schedule-timeouts

eman commented Jul 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eman commented Jul 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants