chore: upgrade nwp500-python to 8.1.3#82
Merged
Conversation
Fixes thread-safety bug in on_connection_resumed where Task.cancel() was called directly from an AWS IoT SDK background thread, allowing the cancellation to be silently dropped under load and causing the MQTT reconnection storm seen in production logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the
nwp500-pythonlibrary from 8.1.2 to 8.1.3.What changed in 8.1.3
Fixes a thread-safety bug where
asyncio.Task.cancel()was called directly from an AWS IoT SDK background thread inon_connection_resumed. When the event loop was busy at the moment of cancellation (e.g. the sleeping task's 1-second timer callback had already been enqueued), the cancellation was silently dropped. The stale_reconnect_with_backofftask would then complete its sleep, call_reconnect_func, and tear down an otherwise healthy connection — restarting the entire disconnect → reconnect →AWS_ERROR_MQTT_UNEXPECTED_HANGUPcycle seen in production logs.See nwp500-python PR #89 for the upstream fix.
Files updated
custom_components/nwp500/manifest.jsonnwp500-python==8.1.3requirements.txtnwp500-python==8.1.3tox.inicoordinator.pyconfig_flow.pyREADME.md.devcontainer/README.md.github/copilot-instructions.mdCHANGELOG.md[Unreleased]