fix/perf: code audit — dead code, apply_odu, close() token, wire map constants, shared refresh callback, id_variants

[eman]

Summary

Full code audit pass. All 234 tests pass, ruff clean, mypy clean before and after.

Fixes

Bugs

• SpaceControls.display_setpoint_str() (models/space.py) — removed 6 lines of dead code in the fallback branch. temperature_setpoint_c is typed float, making the if best is None: guards permanently unreachable. Confirmed by coverage (lines never hit).
• SystemSnapshot.apply_outdoor_unit() (models/system.py) — called dataclasses.replace() up to twice in sequence, creating an intermediate object when both conditions held. Refactored to collect patches into an updates dict and call replace() once, consistent with all other apply_* methods.
• QuiltClient.close() (client.py) — did not clear self._token, leaving a stale token accessible via get_current_token() after the channel was closed. Added self._token = None.

Performance

• FanSpeed.to_wire() / LouverAngle.to_wire() (models/enums.py) — mapping dicts were defined as local variables, re-allocated on every call. Hoisted to module-level constants (_FAN_SPEED_WIRE_MAP, _LOUVER_ANGLE_WIRE_MAP).
• _invoke_refresh_callback (tokens.py, transport.py, services/streaming.py) — the streaming copy lacked the WeakKeyDictionary signature cache present in the transport copy, causing inspect.signature() to be called on every token-refresh event. Extracted a single shared invoke_refresh_callback in tokens.py with the cache; both callers import from there.

Duplication

• _id_variants — lived in models/system.py and duplicated the same strip/rsplit/casefold logic already in models/_helpers.py:lookup_hardware. Moved to _helpers.py and lookup_hardware now calls it.

Minor

• QuiltClient.invalidate_snapshot() log level WARNING → DEBUG. Routine cache invalidation is not a warning condition.

Test / lint

234 passed in 2.38s
ruff: All checks passed
mypy: Success: no issues found in 43 source files

[Copilot]

Pull request overview

This PR is a broad audit/refactor pass across the async Quilt client library, focusing on removing dead code, reducing per-call allocations and introspection overhead, de-duplicating ID-normalization logic, and tightening lifecycle correctness (token clearing on close).

Changes:

• Centralize refresh-callback invocation into tokens.invoke_refresh_callback() with signature caching; update transport/streaming and tests to use it.
• Reduce overhead in hot paths: hoist enum wire mappings to module constants and streamline SystemSnapshot.apply_outdoor_unit() to a single replace().
• De-duplicate ID normalization (_id_variants) and clean up minor behavior/logging + update CHANGELOG.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/test_transport.py	Update tests to call shared invoke_refresh_callback.
tests/test_transport_interceptor_extra.py	Point signature-caching tests at tokens.invoke_refresh_callback + shared cache.
tests/test_streaming.py	Import/alias the shared refresh-callback invoker for streaming tests.
src/quilt_hp/transport.py	Remove local _invoke_refresh_callback and delegate to tokens.invoke_refresh_callback.
src/quilt_hp/tokens.py	Add shared invoke_refresh_callback implementation + signature cache.
src/quilt_hp/services/streaming.py	Remove local _invoke_refresh_callback and delegate to shared implementation.
src/quilt_hp/models/system.py	Import _id_variants from helpers; refactor apply_outdoor_unit() to single replace().
src/quilt_hp/models/space.py	Remove unreachable fallback logic in display_setpoint_str().
src/quilt_hp/models/enums.py	Hoist fan/louver wire maps to module-level constants.
src/quilt_hp/models/_helpers.py	Add _id_variants helper and refactor lookup_hardware() to use it.
src/quilt_hp/client.py	Lower invalidate snapshot log level; clear token on close().
CHANGELOG.md	Document the fixes/changes under Unreleased.

[eman]

Both comments addressed in f10c502. lookup_hardware now uses _id_variant_keys() for deterministic priority order (exact, tail-slash, tail-colon, casefold); _id_variants() also calls it internally so normalization is defined once. Docstring updated to clarify it is the signature introspection result that is cached.