Skip to content

Lower routine transport UNAUTHENTICATED retry logs to INFO#14

Merged
eman merged 2 commits into
mainfrom
bugfix/issue-13-transport-unauth-log-level
Jul 3, 2026
Merged

Lower routine transport UNAUTHENTICATED retry logs to INFO#14
eman merged 2 commits into
mainfrom
bugfix/issue-13-transport-unauth-log-level

Conversation

@eman

@eman eman commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary\n- change transport interceptor retry logs for unary and unary-stream UNAUTHENTICATED retries from WARNING to INFO\n- align transport logging behavior with notifier stream handling for expected token-expiry refreshes\n- add regression tests asserting these retry messages are emitted at INFO\n\n## Validation\n- All checks passed!\n- ........................................................................ [ 26%]

........................................................................ [ 52%]
........................................................................ [ 79%]
........................................................ [100%]
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.14.4-final-0 ________________

Name Stmts Miss Cover Missing

src/quilt_hp/init.py 8 0 100%
src/quilt_hp/_paths.py 8 3 62% 28-30
src/quilt_hp/auth.py 123 43 65% 49-52, 66-67, 80-82, 94-145, 150-168, 269
src/quilt_hp/cli/init.py 0 0 100%
src/quilt_hp/cli/constants.py 7 0 100%
src/quilt_hp/cli/main.py 327 53 84% 17-19, 139, 149-154, 177, 344-405, 412, 428-429, 666-667, 712, 756, 767, 811, 855
src/quilt_hp/cli/settings.py 81 13 84% 36, 44, 82-92
src/quilt_hp/cli/store.py 123 23 81% 37-38, 47, 58-59, 64-66, 107-109, 129-134, 166-168, 181-183
src/quilt_hp/client.py 234 0 100%
src/quilt_hp/const.py 28 0 100%
src/quilt_hp/exceptions.py 6 0 100%
src/quilt_hp/models/init.py 12 0 100%
src/quilt_hp/models/_helpers.py 47 8 83% 24-25, 37, 61, 64, 76, 79, 84
src/quilt_hp/models/comfort.py 35 0 100%
src/quilt_hp/models/controller.py 79 0 100%
src/quilt_hp/models/energy.py 29 0 100%
src/quilt_hp/models/enums.py 200 17 92% 127, 130, 162, 181, 206, 217, 228, 239, 256, 267, 279, 290, 301, 316, 327, 338, 362
src/quilt_hp/models/indoor_unit.py 212 4 98% 189, 279, 379-380
src/quilt_hp/models/outdoor_unit.py 41 2 95% 64-65
src/quilt_hp/models/qsm.py 55 0 100%
src/quilt_hp/models/schedule.py 51 0 100%
src/quilt_hp/models/sensor.py 49 0 100%
src/quilt_hp/models/software_update.py 29 0 100%
src/quilt_hp/models/space.py 109 3 97% 77, 91, 144
src/quilt_hp/models/system.py 347 103 70% 148-150, 198, 203-204, 228, 234, 238, 240, 265, 267, 269, 271, 276-277, 291, 296, 298, 304-306, 311-312, 330, 343, 345, 347, 349-353, 355, 357, 362, 371-373, 378-379, 391, 396, 398, 402, 404, 406, 416-417, 440, 454-455, 461-486, 495-500, 514-516, 529-546, 559
src/quilt_hp/services/init.py 59 3 95% 48, 94-95
src/quilt_hp/services/hds.py 142 1 99% 324
src/quilt_hp/services/streaming.py 512 69 87% 100, 104, 377, 398, 421-422, 426-472, 508, 540, 542, 628-630, 637-638, 648, 662, 688, 735, 758, 767, 769-770, 783, 794-795, 821, 831, 878-882
src/quilt_hp/services/system.py 41 2 95% 34-35
src/quilt_hp/services/user.py 60 3 95% 68-69, 105
src/quilt_hp/tokens.py 66 4 94% 150-151, 159-160
src/quilt_hp/transport.py 81 4 95% 118, 168, 170-171

TOTAL 3201 358 89%
Required test coverage of 80% reached. Total coverage: 88.82%
272 passed in 1.47s\n\nCloses #13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise for routine access-token expiry by lowering the transport interceptor’s UNAUTHENTICATED retry logs from WARNING to INFO, aligning transport behavior with the notifier stream’s expected “token refresh + retry” handling.

Changes:

  • Downgrade interceptor retry logs for unary and unary-stream setup UNAUTHENTICATED paths from logger.warning(...) to logger.info(...).
  • Add regression tests asserting these retry messages are emitted at INFO for both retry sites.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/quilt_hp/transport.py Changes UNAUTHENTICATED retry log level from WARNING to INFO for unary and unary-stream setup retries.
tests/test_transport_interceptor_extra.py Adds caplog-based tests ensuring the retry messages are logged at INFO for both interceptors.

@eman
eman merged commit bdbd5c7 into main Jul 3, 2026
6 checks passed
@eman
eman deleted the bugfix/issue-13-transport-unauth-log-level branch July 3, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants