Conversation
There was a problem hiding this comment.
Line is too long. [127/80]
There was a problem hiding this comment.
A good practice is to create a specific error like InvalidQuorumOption < ArgumentError
Also, if you have to map/select a collection, please use a different variable.
|
Did you consider to create a Quorum class to handle all the methods around quorum? |
|
I'll do a review to this PR by the end of the week |
|
This is an extract of what we are using in a internal project. I agree with you in your comments, but before that, do you agree with the public API?. Is this what you had in mind? (Issue #1) |
|
@damiancaruso I am sorry this PR is taking so long. About the public API, I had two completely different ideas, one is covered in this PR, the other one is something like this: Post.quorum(w: 4).save
Post.quorum(r: 2).reloadI'm not sure right now, I would like to brainstorm about both implementations and API. BTW I don't like to change the |
This adds support for quorum options in
#save,#delete,#reload,::[]and::exists?methods.It adds an options hash as a parameter to the methods mentioned above. The quorum should be set with the
:quorumkey.Usage: