This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Fix deleteRecordForDomain, which returns no body. (Alternative to PR #2) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented on page 24 of the REST API docs, an empty response is returned, not JSON.
Author
|
Hello, any word whether this might be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on PR #2 by updating test coverage. The old test coverage
mocked the wrong response from API, which hid that the related code was broken.
After I corrected the test coverage, it confirmed both that the bug that Victor found was real,
and that his patch corrected the issue.