windows support#19
Merged
Merged
Conversation
…llback, enhance macOS SSH configuration, and add robust connection retries
…v-research#18) * update SSH testing: improve CI environment compatibility with mock fallback, enhance macOS SSH configuration, and add robust connection retries * update tests and workflows: make SSH username dynamic in tests and add concurrency control to GitHub Actions * update workflows: simplify device serial description in bench workflow inputs * update README: revise supported platforms table with expanded host-device compatibility details * update README: revise supported platforms table with expanded host-device compatibility details
…or consistent timestamping, replace `subprocess.Popen` with `subprocess.run` for simpler command execution, enhance filesystem utility robustness, and improve cross-platform path handling
…plify `Mock` return values in subprocess tests, standardize string quotation style, and update README with additional platform compatibility
…ipt, refactor setup script generation for platform detection, and improve CI workflow integration
…es for improved readability and standardization
…penSSH Server installation and configuration logic, streamline SSH connection testing, and improve logging for compatibility checks
… improve interactive and CI pipeline behavior, and enforce strict error handling in SSH setup and device tests
…g spaces in `cli.py` for improved readability and code style consistency
…ption` in `cli.py` for clearer and safer error handling
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…ng for failed SSH connections, streamline macOS SSH daemon startup logic, and add detailed diagnostics for CI environments
…ng for failed SSH connections, streamline macOS SSH daemon startup logic, and add detailed diagnostics for CI environments
…ng unused platform-specific logic
…up and better maintainability
…cy and compatibility
…r installation, configuration updates, improved key handling, and robust connection testing
…0.1` for consistency, remove unused experiment files, and enhance `test_ssh_in_ci` with Paramiko test server integration
…iguration and raise `ConfigError` if missing; minor imports adjustment
…with double quotes for consistency, and apply minor cleanup for improved readability
…d `test_main_all` to handle Windows and Unix separately, ensuring platform compatibility in script generation
…or consistent style and readability
… `ssh_localhost_ci.yaml`, refactor SSH device logic with `mock_mode` for dry-runs, and simplify SSH CI testing with Paramiko test server integration
…ipt, configuration, and test files related to SSH config generation for CI
allnes
added a commit
to allnes/OVMobileBench
that referenced
this pull request
Aug 17, 2025
* update SSH testing: improve CI environment compatibility with mock fallback, enhance macOS SSH configuration, and add robust connection retries * update SSH testing: improve CI environment compatibility (embedded-dev-research#18) * update SSH testing: improve CI environment compatibility with mock fallback, enhance macOS SSH configuration, and add robust connection retries * update tests and workflows: make SSH username dynamic in tests and add concurrency control to GitHub Actions * update workflows: simplify device serial description in bench workflow inputs * update README: revise supported platforms table with expanded host-device compatibility details * update README: revise supported platforms table with expanded host-device compatibility details * refactor tests and core utilities: use `datetime.now(timezone.utc)` for consistent timestamping, replace `subprocess.Popen` with `subprocess.run` for simpler command execution, enhance filesystem utility robustness, and improve cross-platform path handling * refactor tests and core utilities: remove unnecessary whitespace, simplify `Mock` return values in subprocess tests, standardize string quotation style, and update README with additional platform compatibility * update SSH setup and testing: add Windows support with PowerShell script, refactor setup script generation for platform detection, and improve CI workflow integration * refactor tests: remove unnecessary whitespace in SSH-related test files for improved readability and standardization * refactor SSH setup: simplify script for CI environments by removing OpenSSH Server installation and configuration logic, streamline SSH connection testing, and improve logging for compatibility checks * enhance CLI and CI encoding handling: add UTF-8 defaults for Windows, improve interactive and CI pipeline behavior, and enforce strict error handling in SSH setup and device tests * remove unnecessary whitespace: clean up extra blank lines and trailing spaces in `cli.py` for improved readability and code style consistency * handle exceptions explicitly: replace bare `except` with `except Exception` in `cli.py` for clearer and safer error handling * refactor SSH tests and setup: simplify platform checks, enhance logging for failed SSH connections, streamline macOS SSH daemon startup logic, and add detailed diagnostics for CI environments * refactor SSH tests and setup: simplify platform checks, enhance logging for failed SSH connections, streamline macOS SSH daemon startup logic, and add detailed diagnostics for CI environments * remove redundant platform checks: simplify `test_ssh_in_ci` by removing unused platform-specific logic * update SSH testing: remove unused variables in test scripts for cleanup and better maintainability * add shell specification for SSH commands in CI workflow for consistency and compatibility * install and configure OpenSSH Server: enhance CI SSH setup with server installation, configuration updates, improved key handling, and robust connection testing * clean up `test_ssh_in_ci`: adjust formatting for consistent style and readability * update SSH configurations and tests: replace `localhost` with `127.0.0.1` for consistency, remove unused experiment files, and enhance `test_ssh_in_ci` with Paramiko test server integration * validate SSH device config: ensure `host` is specified in device configuration and raise `ConfigError` if missing; minor imports adjustment * format SSH code and tests: adjust indentation, replace single quotes with double quotes for consistency, and apply minor cleanup for improved readability * add platform-specific logic to SSH tests: update `test_main_setup` and `test_main_all` to handle Windows and Unix separately, ensuring platform compatibility in script generation * refactor SSH tests: adjust formatting in `test_generate_ssh_config` for consistent style and readability * remove SSH localhost experiments and enhance mock mode: delete unused `ssh_localhost_ci.yaml`, refactor SSH device logic with `mock_mode` for dry-runs, and simplify SSH CI testing with Paramiko test server integration * remove generate_ssh_config.py and associated files: delete unused script, configuration, and test files related to SSH config generation for CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.