Add startup health check for cron/browser services#16
Merged
Conversation
curl calls in check_services() had no timeout, so an unreachable-but-not- refusing host could hang the "non-blocking" health check. Also adds coverage for the warning-log path and the bash SERVICE_DOWN output, both previously untested. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cron.system_status.check_services()to probe the cron server and browser CDP endpoint, logging a warning for whichever is unreachablebin/outreach-update-checknow also emitsSERVICE_DOWN <service> <url>lines alongside the existing version checktools/server.py's background startup check now runs both the upgrade check and the new service health probe (renamed to_run_system_check)Test plan
testing/tests/test_system_status.py::test_check_services_returns_both_probescovers the new probemake status/ server startup logs show health warnings when cron/browser are downCloses #12