Preserve persona.json/conversation_planner.json across outreach-upgrade#21
Merged
huangruoqi merged 1 commit intoJul 9, 2026
Merged
Conversation
Upgrading across a point where upstream renamed a tracked config file to .example could leave a user's local edits stuck in the stash with nothing at the live path, silently falling back to default config. Back the two config files up before stash/pull and restore them unconditionally afterward, and auto-run `git stash pop` instead of just printing a reminder. Bump to 1.0.0.13. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
ReviewTraced the full script flow ( What I verified:
Pre-existing, not introduced by this diff: if LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outreach-upgradecould silently lose a user'spersona.json/conversation_planner.jsonedits: it stashes local changes beforegit pull --ff-onlybut only printed a reminder to manually rungit stash popafterward. If upstream had renamed a tracked config to.example(as happened historically for these two files), the stashed edits could end up merged into the.examplefile or stuck in the stash, leaving the live config path empty — the server then silently falls back to default config with no error.git stash popafter the pull instead of leaving it to the user to remember.Test plan
bash -n bin/outreach-upgrade(syntax check)conversation_planner.jsontracked directly with local edits; upstream renames it to.exampleand gitignores the live path; ranoutreach-upgradeagainst it — confirmed the user's original content ends up at the live pathoutreach/config/conversation_planner.jsonafter upgrade, not the default.examplecontent.