Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the import lazy-loading whitelist to reflect that the simulation optional dependency chain (via xyzpy) no longer pulls in scipy, so baybe._optional.simulation should not be exempted from the “don’t import scipy eagerly” rule.
Changes:
- Remove the Python-version-conditional whitelist entry that allowed
baybe._optional.simulationto importscipy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Scienfitz
approved these changes
Apr 23, 2026
No longer a transient dependency due to upstream changes
AdrianSosic
force-pushed
the
repo/whitelist
branch
from
21d05cd to
0050502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our dependencies seem to have dropped scipy from their own deps, meaning that the whitelist entry is no longer needed. Which dependency it was (probably xyzpy, xarray or related) is not important at this point.