Skip to content

feat: Add exception to onVerificationFailed callback#35

Merged
flxapps merged 2 commits intodevfrom
feat/add-exception-to-verification-failed-callback
Oct 8, 2025
Merged

feat: Add exception to onVerificationFailed callback#35
flxapps merged 2 commits intodevfrom
feat/add-exception-to-verification-failed-callback

Conversation

@flxapps
Copy link
Copy Markdown

@flxapps flxapps commented Oct 7, 2025

Updated the onIdentificationFailed callback to include an ImpReaderException parameter, providing detailed error information to consumers.

Breaking Changes

⚠️ This is a breaking change

All consumers must update their onIdentificationFailed callback:

Before:

onIdentificationFailed: () {
  print('Identification failed');
}

After:

onIdentificationFailed: (exception) {
  print('Identification failed: ${exception.message}');
}

@flxapps flxapps self-assigned this Oct 7, 2025
Copilot AI review requested due to automatic review settings October 7, 2025 11:11
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 7, 2025

CLA assistant check
All committers have signed the CLA.

@flxapps flxapps changed the base branch from main to dev October 7, 2025 11:12
@flxapps flxapps force-pushed the feat/add-exception-to-verification-failed-callback branch from b37209a to 8fd5f12 Compare October 7, 2025 11:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@flxapps flxapps requested a review from JoshuaWell October 7, 2025 12:33
Copy link
Copy Markdown
Collaborator

@JoshuaWell JoshuaWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@flxapps flxapps merged commit 6a91e00 into dev Oct 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants