Merged
Conversation
|
|
flxapps
force-pushed
the
fix/compatibility-with-urp-core-9.1.0-13
branch
from
a62387a to
574ea39
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the mtrust_imp_kit package to be compatible with mtrust_urp_core version 9.1.0-13. The changes reflect API modifications in the CmdWrapper interface, where addCoreCmdToQueue() becomes the required implementation method while the pair() method is removed from the interface contract.
Changes:
- Updated dependencies to mtrust_urp_core and mtrust_urp_ui version 9.1.0-13
- Implemented required
addCoreCmdToQueue()method in ImpReader to satisfy CmdWrapper interface - Removed
pair()method which is no longer part of CmdWrapper interface - Added pubspec.lock to .gitignore and removed committed lock files from example directories
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Bumped mtrust_urp_core and mtrust_urp_ui from 9.1.0-12 to 9.1.0-13 |
| lib/src/imp_reader.dart | Added addCoreCmdToQueue() method and removed pair() method per CmdWrapper interface changes |
| example/example_advanced/pubspec.lock | Removed committed lockfile (now gitignored) |
| example/example_advanced/.gitignore | Added pubspec.lock to ignored files |
| example/example/pubspec.lock | Removed committed lockfile (now gitignored) |
| example/.gitignore | Added pubspec.lock patterns for example subdirectories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small
ImpReadercleanup to fix wrapper/API issues and restore missing command wiring.Changes
addCoreCmdToQueue(UrpCoreCommand)as the requiredCmdWrapperimplementation.pair()method, since it is not required byCmdWrapperanymore_addCommandToQueue(...)helper as the shared queue path for core and device commands.Impact
No intended behavior change outside of fixing the incomplete/missing command setup