Skip to content

problem: content-type and status are set incorrectly in spring-web #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
splix merged 1 commit into from
Mar 17, 2025
Merged

problem: content-type and status are set incorrectly in spring-web #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions doubleview-spring-web/src/main/java/io/emeraldpay/doubleview/spring/web/DoubleView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.emeraldpay.doubleview.spring.web;

import io.emeraldpay.doubleview.DoubleViewRenderer;
import jakarta.servlet.RequestDispatcher;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import org.springframework.http.MediaType;
Expand All @@ -20,13 +21,18 @@ public DoubleView(DoubleViewRenderer renderer, String componentName) {

@Override
public String getContentType() {
return MediaType.TEXT_HTML.getType();
return MediaType.TEXT_HTML_VALUE;
}

@Override
public void render(Map<String, ?> model, HttpServletRequest request, HttpServletResponse response) throws Exception {
String rendered = renderer.render(componentName, (Map<String, Object>) model);
response.setStatus(200);
Object status = request.getAttribute(RequestDispatcher.ERROR_STATUS_CODE);
if (status != null && status instanceof Integer) {
response.setStatus((int) status);
} else {
response.setStatus(200);
}
response.getOutputStream().write(rendered.getBytes());
}

Expand Down
Loading