Skip to content

Rename chain id#300

Merged
r8d8 merged 3 commits intoemeraldpay:masterfrom
r8d8:issue/chain_id
Nov 6, 2018
Merged

Rename chain id#300
r8d8 merged 3 commits intoemeraldpay:masterfrom
r8d8:issue/chain_id

Conversation

@r8d8
Copy link
Copy Markdown
Contributor

@r8d8 r8d8 commented Nov 2, 2018

@ghost ghost assigned r8d8 Nov 2, 2018
@ghost ghost added the review label Nov 2, 2018
@splix
Copy link
Copy Markdown
Member

splix commented Nov 2, 2018

I'm wondering, what will happen if a user will try to specify just usual mainnet?

@r8d8
Copy link
Copy Markdown
Contributor Author

r8d8 commented Nov 4, 2018

Will get invalid argument error, as it's not obvious what does he mean.

@splix
Copy link
Copy Markdown
Member

splix commented Nov 4, 2018

it shouldn't be error, It should run mainnet. Same as geth

@r8d8 r8d8 requested review from splix, tzdybal and whilei November 5, 2018 14:39
@r8d8 r8d8 merged commit 743c856 into emeraldpay:master Nov 6, 2018
@ghost ghost removed the review label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants