Support landscape on iPhone#86
Open
ruri1208 wants to merge 63 commits into
Open
Conversation
Commented out checks for userInterfaceIdiom.
Commented out device-specific UI adjustments for phones and pads.
Calculate safe area insets and adjust window rect accordingly.
Comment out code related to fullscreen rectangle calculation and maximized window handling.
Comment out the conditional check for phone interface idiom.
Removed duplicate declaration of viewControllers array.
Updated view controllers array to include appViewController conditionally based on iOS version.
Removed unnecessary build settings for iOS archive.
Removed deprecated code for appViewController in SceneDelegate.
Add steps to download LLVM and CoreCompilerSupportLibs from GitHub Actions.
Updated the dependency copying commands to check for directory existence before copying, enhancing robustness.
Removed copying of LLVM.xcframework to support libs.
Updated the build workflow to create the Shared/SwiftToolchain directory and adjusted the download paths for LLVM.xcframework.
Remove Shared/SwiftToolchain directory before copying files.
Comment out the Applications case in SettingsViewController.
Removed unused methods for app switcher height and view transition handling. Updated constraints for running apps scroll view and app switcher view.
Added a method to check multitasking status and updated window management methods to respect this setting.
Member
|
yes, but I think most of Duy Tran's decisions are just right out wrong. |
Member
|
Duy Tran used 2000~ ish fucking branches to replace 2 pointers. |
Member
|
Duy Tran is a good hacker, but not a good engineer |
Refactor window movement and maximize logic based on multitasking support.
Added functionality to toggle multitasking and update button state.
Remove unnecessary whitespace and update multitasking state handling.
Removed the isMultitaskingEnabled method as it was redundant.
Author
|
@mach-port-t |
Added multitasking state observer and updated tab bar items accordingly.
Removed commented-out instantiation of themedTabViewController.
Refactor height multiplier calculation and add app switcher height constraint.
Adjust app switcher height constraint based on device type and orientation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support landscape on iPhone
ScreenRecording_07-23-2026.01-45-37_1.mov
Build ipa fast (less than 10 minutes)