Skip to content

[GRX-123456] Adding missing Dip Switch Settings for Double Dragon 2 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emfloyd2 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[GRX-123456] Adding missing Dip Switch Settings for Double Dragon 2 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions fbarr/src/burn/drivers/misc_pre90s/d_ddragon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,22 @@ static struct BurnDIPInfo Drv2DIPList[]=
{0x14, 0x01, 0x80, 0x00, "On" },

// Dip 2
// Note the difficulty settings were pulled from MAME
// Do not use the real Double Dragon 2 Manual as
// reference, because it lists wrong settings!
//
// If anyone points you to bad settings from Manual
// they will look like this:
Copy link
Copy Markdown
Owner Author

@emfloyd2 emfloyd2 Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit]
Fix alignment of comments

// OFF OFF = Normal
// OFF OFF = Easy
// ON OFF = Less Than Difficult
// ON ON = Difficult
Copy link
Copy Markdown
Owner Author

@emfloyd2 emfloyd2 Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to original Manual if you can find it

{0 , 0xfe, 0 , 4 , "Difficulty" },
{0x15, 0x01, 0x03, 0x01, "Easy" },
{0x15, 0x01, 0x03, 0x03, "Medium" },
{0x15, 0x01, 0x03, 0x02, "Hard" },
{0x15, 0x01, 0x03, 0x00, "Hardest" },

{0 , 0xfe, 0 , 2 , "Hurricane Kick" },
{0x15, 0x01, 0x08, 0x00, "Easy" },
{0x15, 0x01, 0x08, 0x08, "Normal" },
Expand Down