-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add retry logic #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emilioSp
wants to merge
4
commits into
main
Choose a base branch
from
feat/retry-logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b066694
feat: add retry logic
emilioSp 3b9a6af
Update migrations/20260128113327_add_retry_logic.ts
emilioSp e2fd922
Update migrations/20260128113327_add_retry_logic.ts
emilioSp 934d181
Rename max_retries to max_attempts for semantic clarity (#2)
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import type { Knex } from 'knex'; | ||
|
|
||
| export async function up(knex: Knex): Promise<void> { | ||
| // Add retry columns | ||
| await knex.raw( | ||
| `ALTER TABLE tasks ADD COLUMN retry_count INTEGER NOT NULL DEFAULT 0;`, | ||
| ); | ||
| await knex.raw( | ||
| `ALTER TABLE tasks ADD COLUMN max_attempts INTEGER NOT NULL DEFAULT 3;`, | ||
| ); | ||
| await knex.raw(`ALTER TABLE tasks ADD COLUMN error_message TEXT;`); | ||
|
|
||
| await knex.raw(`ALTER TYPE t_status ADD VALUE IF NOT EXISTS 'failed';`); | ||
| } | ||
|
|
||
| export async function down(knex: Knex): Promise<void> { | ||
| await knex.raw(`ALTER TABLE tasks DROP COLUMN retry_count;`); | ||
| await knex.raw(`ALTER TABLE tasks DROP COLUMN max_attempts;`); | ||
| await knex.raw(`ALTER TABLE tasks DROP COLUMN error_message;`); | ||
|
|
||
| // Note: PostgreSQL does not support simply removing values from enums. | ||
| // The 'failed' value will remain in t_status; only the added columns are rolled back. | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.