[codex] fix stale config during plugin update - #4
Merged
AlwinGarside merged 5 commits intoMay 9, 2026
Merged
Conversation
Composer can keep helper classes loaded from the old plugin version while eval-loading the new plugin class during an update. Guarding the new duplicate service-mapping API prevents the update from failing when projects already use service-mapping. Add an integration regression that installs the old plugin commit and updates to the current package.
The regression installed the old plugin from the local checkout as a VCS repository, but GitHub Actions checks out pull requests as shallow detached merge refs without usable branch or tag metadata. Use the canonical GitHub VCS repository for the old install and keep the local path repository for the update under test.
Composer 1 does not provide the minimal-changes require option used by the regression. Build the require command from the active integration Composer version so the update path is still covered across the CI matrix.
Pinned Composer versions in the integration matrix do not all support the require --minimal-changes option. Keep that option for the floating current Composer v2 case and use the broadly supported require command for historical versions.
AlwinGarside
force-pushed
the
codex/fix-call-to-undefined-getDuplicateServiceMappingScripts
branch
4 times, most recently
from
May 9, 2026 22:21
eab8c9a to
a772d52
Compare
AlwinGarside
force-pushed
the
codex/fix-call-to-undefined-getDuplicateServiceMappingScripts
branch
from
May 9, 2026 22:25
a772d52 to
d0fac23
Compare
Code Coverage Summary (ubuntu)
|
Code Coverage Summary (windows)
|
AlwinGarside
marked this pull request as ready for review
May 9, 2026 22:27
AlwinGarside
deleted the
codex/fix-call-to-undefined-getDuplicateServiceMappingScripts
branch
May 9, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation