Move __syscall__newselect to native code. NFC
#25985
Merged
+25
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
__syscall__newselect
branch
from
6699975 to
4b49968
Compare
sbc100
force-pushed
the
__syscall__newselect
branch
from
4b49968 to
782af69
Compare
kripken
reviewed
Dec 19, 2025
sbc100
force-pushed
the
__syscall__newselect
branch
from
782af69 to
c1fa4aa
Compare
sbc100
force-pushed
the
__syscall__newselect
branch
from
c1fa4aa to
d922a06
Compare
After emscripten-core#25523 this function is no longer proxied itself and therefore doesn't need to live in JS at all.
sbc100
force-pushed
the
__syscall__newselect
branch
from
d922a06 to
6883967
Compare
Collaborator
Author
|
Landing TBR since it seems fairly trivial and i have followups. |
dschuff
reviewed
Dec 19, 2025
| "a.out.nodebug.wasm": 573904, | ||
| "total": 819675, | ||
| "a.out.js": 245592, | ||
| "a.out.nodebug.wasm": 573702, |
Member
There was a problem hiding this comment.
Impressive that both JS and wasm managed to get smaller 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #25523 this function is no longer proxied itself and therefore doesn't need to live in JS at all.