Remove unnessary to64 casts from newselect system. NFC #25987
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added unnecessarily in emscripten-core#25523. `_emscripten_proxy_newselect_finish` was added to `create_pointer_conversion_wrappers` in emscripten.py which makes these conversions automatic.
Collaborator
Author
|
Will likely land TBR if tests pass |
dschuff
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added unnecessarily in #25523.
_emscripten_proxy_newselect_finishwas added tocreate_pointer_conversion_wrappersin emscripten.py which makes these conversions automatic.