Honor FD_SETSIZE for file descriptor sets passed to select #25989
+71
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm actually hoping to completely delete this select() implementation in JS and instead simply implement poll() in JS only. We already have a select-on-top-of-poll implemention for wasmfs and my proposed change just moves it. My WIP is here: #25990 |
sbc100
reviewed
Dec 20, 2025
| FD_SET(server.fd, &fdr); | ||
| FD_SET(server.fd, &fdw); | ||
| res = select(64, &fdr, &fdw, NULL, &tv); | ||
| res = select(FD_SETSIZE, &fdr, &fdw, NULL, &tv); |
Collaborator
There was a problem hiding this comment.
Hmm, this is not how select is supposed to work. This should be server.fd + 1 I think,
nfds This argument should be set to the highest-numbered file descriptor in any of the three sets, plus 1. The indicated file descriptors in each set are checked, up
to this limit (but see BUGS).
Collaborator
There was a problem hiding this comment.
Would you be up for making that change instead as a separate PR?
Collaborator
Author
There was a problem hiding this comment.
@sbc100 yah, I would expect maxfd + 1 to be passed, but I guess you could technically pass anything up to the max size providing the sets are zero'd out.
I just saw the 64 and changed it to match.
Collaborator
Author
|
Closing in favor of #25990. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just hit this after adding a bunch of new assets to a server, which were loaded before the listen socket was setup.