[NODERAWFS] Fix getcwd() on Windows - #27738
Merged
Merged
Conversation
In upstream musl, `getcwd()` checks `buf[0] != '/'` to detect the Linux kernel's `(unreachable)` prefix returned by `sys_getcwd`. Emscripten's `__syscall_getcwd` never returns `(unreachable)`, and under `NODERAWFS` on Windows `process.cwd()` returns paths starting with a drive letter (e.g. `C:\...`) or UNC prefix (`\\...`), which caused `getcwd()` to fail with `ENOENT`. Skip the `buf[0] != '/'` check on Emscripten and add a `@crossplatform` `test_noderawfs_getcwd` test so it runs on Windows CI. Fixes: emscripten-core#25291
sbc100
force-pushed
the
fix_getcwd_noderawfs
branch
from
September 17, 2026 19:14
967d2cb to
8525ddc
Compare
kripken
reviewed
Sep 17, 2026
kripken
approved these changes
Sep 17, 2026
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In upstream musl,
getcwd()checksbuf[0] != '/'to detect the Linux kernel's(unreachable)prefix returned bysys_getcwd. Emscripten's__syscall_getcwdnever returns(unreachable), and underNODERAWFSon Windowsprocess.cwd()returns paths starting with a drive letter (e.g.C:\...) or UNC prefix (\\...), which causedgetcwd()to fail withENOENT.Skip the
buf[0] != '/'check on Emscripten and add a@crossplatformtest_noderawfs_getcwdtest so it runs on Windows CI.Fixes: #25291