Remove NODE_CODE_CACHING setting - #27740
Merged
Merged
Conversation
V8 removed support for serializing compiled `WebAssembly.Module` objects via `v8.serialize()` / `v8.deserialize()` over 5 years ago: nodejs/node#18265. As a result, `-sNODE_CODE_CACHING` has not worked in any version of Node.js since Node 12, and `test_node_code_caching` has been disabled since emscripten-core#13489 (February 2021). Move `NODE_CODE_CACHING` to `LEGACY_SETTINGS` for backwards compatibility with `-sNODE_CODE_CACHING=0`. See: emscripten-core#13128
kripken
approved these changes
Sep 17, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
Sad this was never fixed... but I guess wasm is fast enough without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node removed support for serializing compiled
WebAssembly.Moduleobjects viav8.serialize()/v8.deserialize()over 5 years ago: nodejs/node#18265.As a result,
-sNODE_CODE_CACHINGhas not worked in any version of Node.js since Node 12, andtest_node_code_cachinghas been disabled since #13489 (February 2021).Move
NODE_CODE_CACHINGtoLEGACY_SETTINGSfor backwards compatibility with-sNODE_CODE_CACHING=0.See: #13128