Enable more ruff checks, part 6. NFC - #27741
Merged
Merged
Conversation
sbc100
requested review from
dschuff and
kripken
and removed request for
dschuff
September 17, 2026 20:30
kripken
approved these changes
Sep 17, 2026
| # If `total` if not in the json dict then just use the first key. This happens when only one | ||
| # file size is reported (in this case we don't calculate or store the `total`). | ||
| first_key = list(json_data.keys())[0] | ||
| first_key = next(iter(json_data.keys())) |
Member
There was a problem hiding this comment.
Not a fan of this one but I guess it is faster...
Collaborator
Author
There was a problem hiding this comment.
I kind of agree... but I also think its better to just go with the recommendations in cases like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the last one in the series I think.