Fix FP16 NEON build on AArch64 CPUs without FP16FML support#168
Open
Harish-endee wants to merge 1 commit intomasterfrom
Open
Fix FP16 NEON build on AArch64 CPUs without FP16FML support#168Harish-endee wants to merge 1 commit intomasterfrom
Harish-endee wants to merge 1 commit intomasterfrom
Conversation
Some AArch64 CPUs don't support the FP16FML extension, which causes builds to fail due to missing vfmlalq_low_f16 and vfmlalq_high_f16 intrinsics. This adds compatibility fallbacks that use universally available NEON instructions (vcvt_f32_f16 + vfmaq_f32) instead, with automatic compile-time dispatch so CPUs with FP16FML still use the native single-instruction path.
VectorDB Benchmark - Ready To Run
Post one of the command below. Only members with write access can trigger runs. Available Modes
Infrastructure
Both servers start on demand and are always terminated after the run — pass or fail. How Correctness Benchmarking Works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FP16 NEON distance functions (L2Sqr, InnerProductSim) rely on vfmlalq_low_f16 and vfmlalq_high_f16 intrinsics. These intrinsics require the AArch64 FP16FML extension. Not all AArch64 CPUs support FP16FML, leading to compilation failures on unsupported targets.
Added compatibility fallback implementations