🎨 Palette: Improve accessibility of icon-only toggle buttons in settings - #233
🎨 Palette: Improve accessibility of icon-only toggle buttons in settings#233endlessblink wants to merge 1 commit into
Conversation
…tings Adds dynamic `:aria-label` bindings to the password and API key visibility toggle buttons, as well as the local API token copy button, to improve screen reader accessibility and convey the current action accurately. Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added dynamically bound
:aria-labelattributes to the icon-only toggle buttons in the settings modal (specifically, the password visibility toggle, Groq API key visibility toggle, and the local API token copy button).🎯 Why: Icon-only buttons without accessible text are invisible or confusing to screen reader users. Furthermore, since these buttons toggle state (show/hide), a static label is insufficient. Dynamically binding the label based on state ensures that users relying on assistive technology understand the precise action the button will perform (e.g., "Hide API key" instead of just "Toggle API key").
📸 Before/After: Visual changes are nil, this is a purely semantic/accessibility update.
♿ Accessibility: Significantly improves screen reader comprehension for crucial account management operations by providing exact text descriptions that match the current toggle state.
PR created automatically by Jules for task 477773516366916464 started by @endlessblink