Skip to content

🎨 Palette: Add aria-labels to icon-only buttons - #235

Open
endlessblink wants to merge 2 commits into
masterfrom
ux/palette-add-missing-aria-labels-8574027396957991474
Open

🎨 Palette: Add aria-labels to icon-only buttons#235
endlessblink wants to merge 2 commits into
masterfrom
ux/palette-add-missing-aria-labels-8574027396957991474

Conversation

@endlessblink

Copy link
Copy Markdown
Owner

💡 What: Added missing aria-label attributes to icon-only buttons across multiple components (CanvasContextMenu, MiniCanvasToolbar, SidebarLanesSection, SidebarProjectsSection, SidebarUserFooter).
🎯 Why: To improve screen reader accessibility. Relying solely on the title attribute for icon-only buttons provides inconsistent experiences for visually impaired users.
♿ Accessibility: Explicit aria-label attributes were added to ensure consistent screen reader interpretation matching the intended action.


PR created automatically by Jules for task 8574027396957991474 started by @endlessblink

* Added missing `aria-label` attributes to multiple icon-only buttons across Vue components.
* Bound translated titles to `aria-label` where applicable (e.g., settings buttons, add project).
* Included journal entry in `.Jules/palette.md` detailing the importance of explicit `aria-label` attributes over relying on just `title`.

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

… rate limit

* Added missing `aria-label` attributes to multiple icon-only buttons across Vue components.
* Bound translated titles to `aria-label` where applicable (e.g., settings buttons, add project).
* Included journal entry in `.Jules/palette.md` detailing the importance of explicit `aria-label` attributes.
* Replaced `supabase/setup-cli@v1` with local `npm install supabase` in `.github/workflows/ci.yml` and updated `scripts/run-e2e.sh` to use `npx supabase` to mitigate GitHub API rate limits affecting the CI check runner.

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant