Skip to content

🎨 Palette: Dynamic ARIA labels for icon-only toggle buttons - #237

Open
endlessblink wants to merge 2 commits into
masterfrom
palette/dynamic-aria-labels-icon-toggles-11585326306290939927
Open

🎨 Palette: Dynamic ARIA labels for icon-only toggle buttons#237
endlessblink wants to merge 2 commits into
masterfrom
palette/dynamic-aria-labels-icon-toggles-11585326306290939927

Conversation

@endlessblink

Copy link
Copy Markdown
Owner

💡 What: Added dynamic :aria-label and title attributes to icon-only toggle buttons in AccountSettingsTab and AISettingsTab.
🎯 Why: Screen readers need to know exactly what an icon-only button does, and the action changes when toggled (e.g., "Show password" becomes "Hide password"). Static labels or missing labels provide a poor UX for assistive technology users.
Accessibility: Significant improvement for screen reader users and keyboard navigation tooltips.


PR created automatically by Jules for task 11585326306290939927 started by @endlessblink

…ttings

Adds dynamic `:aria-label` and `title` attributes to icon-only toggle buttons
in AccountSettingsTab (Show/Hide password, Copy API token) and AISettingsTab
(Show/Hide Groq API key).

This improves screen reader accessibility by announcing the correct action
based on the current state, and provides better tooltip context for mouse users.

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Removes the deprecated `supabase/setup-cli@v1` GitHub Action (which fails on Node 20 deprecations and rate limits) from the `canvas-sync` workflow, replacing it with direct execution of the local `npx supabase` dependency.

Also updates `scripts/run-e2e.sh` to explicitly call `npx supabase status` to prevent fallback errors when extracting local Supabase keys, resolving the "Local Supabase is missing public.canonical_change_log" E2E failure caused by unapplied migrations.

Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant